fix DriverListAllocationPaymentManager._get_allocation
#257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucekdudek
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
LGTM but @approxit had some specific idea for this class in regard to Yagna versions so please wait for his review 😄
approxit
suggested changes
Aug 16, 2024
There was a problem hiding this comment.
The problem is not related to the yagna version, it is related to the older version of golem-core. golem-core 0.7.5 and DriverListAllocationPaymentManager from golem-workers should do the job.
shadeofblue
force-pushed
the
blue/fix-get-allocation
branch
from
5d7e512 to
f564092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for:
node0: Failed to create activity: builtins.TypeError: DriverListAllocationPaymentManager._create_allocation() missing 3 required positional arguments: 'budget', 'network', and 'driver'found while testing the 0.16 rc