Cluster cleanup #246
Merged
Cluster cleanup #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucekdudek
approved these changes
Jun 4, 2024
shadeofblue
reviewed
Jun 5, 2024
ray_on_golem/server/services/ray.py
Outdated
| async def _on_cluster_stop(self, cluster: Cluster) -> None: | ||
| cluster_name = str(cluster) | ||
|
|
||
| logger.info(f"Cluster `%s` stopped, it will be removed after 30 seconds", cluster_name) |
There was a problem hiding this comment.
please use the defined timeout constant instead of hardcoding the text
shadeofblue
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I've done:
Clusterinstead of being kept in the memory, it could be auto-removed after a specific time or be overridden by a new cluster before that timeout. This helps with consecutiveray downandray up.on_stopevents inCluster,ClusterNode, and `ClusterNodeSidecar. They spawn separate asyncio tasks by default.priority_subnet_tagnot being correctly handled.total_budgetfrom1to5.Notable remarks:
ray upwith the same name but with different configs results in ray-specific errors, we decided that currently, we will not implement any additional warnings/guards about that.