Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU support + examples #203

Merged
merged 2 commits into from
Mar 5, 2024
Merged

GPU support + examples #203

merged 2 commits into from
Mar 5, 2024

Conversation

shadeofblue
Copy link
Contributor

  • add support for the vm-nvidia runtime
  • add a GPU Dockerfile
  • add examples utilizing GPU on ray-on-golem

@shadeofblue shadeofblue self-assigned this Feb 29, 2024
* add a GPU Dockerfile
* add examples utilizing GPU on ray-on-golem
Copy link
Contributor

@lucekdudek lucekdudek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

rsync \
vim \
curl \
wget \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stick to one: tabulators or spaces

node_config:
# Parameters for golem demands (same for head and workers)
demand:
image_tag: "blueshade/raytest:0.9.0-py3.10-ray2.9.2-cuda11.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change raytest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if I get the question but anyway, yeah, maybe we can upload the image to the production repo in the registry when we release a new version... otherwise, we never put images from develop in the golem/ray-on-golem repo...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raytest is a very raw name for an image. Can we change it to something more descriptive and accurate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not the name of the image, that's the name of the repository... but anyway, yeah, we can

from numba import cuda


def test(v: np.array):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this function or add PyDoc please



@ray.remote(num_gpus=1)
def cuda_test(width, height):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this function or add PyDoc please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, on second thought, this one seems quite accurate...

examples/mandelbrot_image_gpu.py Show resolved Hide resolved
@shadeofblue shadeofblue merged commit cd6295b into develop Mar 5, 2024
2 checks passed
@shadeofblue shadeofblue deleted the blue/gpu branch March 5, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants