-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU support + examples #203
Conversation
* add a GPU Dockerfile * add examples utilizing GPU on ray-on-golem
c53486f
to
a7c8bf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments
examples/GPU.Dockerfile
Outdated
rsync \ | ||
vim \ | ||
curl \ | ||
wget \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please stick to one: tabulators or spaces
examples/gpu.yaml
Outdated
node_config: | ||
# Parameters for golem demands (same for head and workers) | ||
demand: | ||
image_tag: "blueshade/raytest:0.9.0-py3.10-ray2.9.2-cuda11.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change raytest
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if I get the question but anyway, yeah, maybe we can upload the image to the production repo in the registry when we release a new version... otherwise, we never put images from develop
in the golem/ray-on-golem
repo...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raytest
is a very raw name for an image. Can we change it to something more descriptive and accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's not the name of the image, that's the name of the repository... but anyway, yeah, we can
examples/hello_gpu.py
Outdated
from numba import cuda | ||
|
||
|
||
def test(v: np.array): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename this function or add PyDoc please
|
||
|
||
@ray.remote(num_gpus=1) | ||
def cuda_test(width, height): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename this function or add PyDoc please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, on second thought, this one seems quite accurate...
vm-nvidia
runtime