Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goth examples on CI #198

Merged
merged 16 commits into from
Mar 8, 2024
Merged

Goth examples on CI #198

merged 16 commits into from
Mar 8, 2024

Conversation

approxit
Copy link
Contributor

@approxit approxit commented Feb 27, 2024

What I've done:

  • Added all non-outbound vm examples on CI to be run nightly at 2 AM
  • Removed default usage of outbound pypi URL (to ease example running)
  • Fixed Terminate node does not cancel its pending creation #197
  • Made SSH check fails able to retry activity creation
  • Removed hostname resolution dependency in simple-task and simple-actor examples, as sometimes goth instances had problems with their stability
  • Fixed outdated node_config layout in mendelbrot yaml example
  • Made node_config raise errors on unrecognized fields (to mitigate the previous element from this list)
  • Fixed CI warnings about outdated node versions, by bumping versions of a few GHA steps
  • Made yagna running checks explicit about the used URL
  • Fixed problems with failing yagna funds on CI, by making its timeout a little bigger

Notable remarks:

  • We decided that examples will be run not on pull requests and as nighty due to current problems with ssh stability

@approxit approxit changed the base branch from main to develop February 27, 2024 12:02
@approxit approxit force-pushed the approxit/examples-in-ci branch from 2b1e170 to 175dced Compare March 7, 2024 17:46
@approxit approxit force-pushed the approxit/examples-in-ci branch from 175dced to d0ae278 Compare March 7, 2024 17:55
@approxit approxit changed the title Examples in ci Goth examples on CI Mar 7, 2024
@approxit approxit marked this pull request as ready for review March 7, 2024 19:25
golem-cluster.override.2-image.yaml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/start-goth.sh Outdated Show resolved Hide resolved
.github/workflows/integration_tests.yml Outdated Show resolved Hide resolved
.github/workflows/integration_tests.yml Show resolved Hide resolved
@approxit approxit requested a review from lucekdudek March 8, 2024 12:06
pyproject.toml Outdated Show resolved Hide resolved
@approxit approxit requested a review from lucekdudek March 8, 2024 13:32
@approxit approxit merged commit 679980d into develop Mar 8, 2024
2 checks passed
@approxit approxit deleted the approxit/examples-in-ci branch March 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants