Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for outboud_urls in yaml and no manifest requirement #123

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Add support for outboud_urls in yaml and no manifest requirement #123

merged 4 commits into from
Nov 23, 2023

Conversation

lucekdudek
Copy link
Contributor

@lucekdudek lucekdudek commented Nov 17, 2023 •
edited
Loading

What have been done:

  • Added support for non-manifest demands
  • Config YAML: capabilities field defaults to ["vpn", "inet"],
  • Config YAML: added new field outbound_urls which dictates if manifest will be added to a demend, it also ensures that "manifest-support" is present in capabilities
  • Added golem-cluster.mini.yaml with required fields only

@lucekdudek lucekdudek self-assigned this Nov 17, 2023
@lucekdudek lucekdudek force-pushed the ld/repository-vm-payload branch 2 times, most recently from 3b61133 to ac29429 Compare November 21, 2023 13:35
@lucekdudek lucekdudek marked this pull request as ready for review November 21, 2023 13:47
mateuszsrebrny
mateuszsrebrny reviewed Nov 21, 2023
View reviewed changes
golem-cluster.yaml Outdated Show resolved Hide resolved
@lucekdudek lucekdudek force-pushed the ld/repository-vm-payload branch from 158f10e to ac29429 Compare November 22, 2023 09:25
@lucekdudek lucekdudek force-pushed the ld/repository-vm-payload branch from 8d53102 to 8821a47 Compare November 22, 2023 09:37
shadeofblue
shadeofblue approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, minor comments added

golem-cluster.mini.yaml Show resolved Hide resolved
ray_on_golem/server/services/golem/helpers/demand_config.py Outdated Show resolved Hide resolved
ray_on_golem/server/services/golem/helpers/demand_config.py Outdated Show resolved Hide resolved
@lucekdudek lucekdudek merged commit db46def into develop Nov 23, 2023
@lucekdudek lucekdudek deleted the ld/repository-vm-payload branch November 23, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszsrebrny mateuszsrebrny mateuszsrebrny left review comments

@approxit approxit approxit approved these changes

@shadeofblue shadeofblue shadeofblue approved these changes

Assignees

@lucekdudek lucekdudek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucekdudek @mateuszsrebrny @approxit @shadeofblue