[GSCOLLECT-1410] Fix array index bug in <Primitive>ArrayList.sortThis…

…(). Fixes #16. git-svn-id: svn+ssh://gscollections.svn.services.gs.com/svnroot/gscollections-svn/trunk@646 d5c9223b-1aff-41ac-aadd-f810b4a99ac4
goldmansachs · Aug 22, 2014 · c93576e · c93576e
1 parent 3d6d064
commit c93576e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/gs-collections-code-generator/src/main/resources/impl/list/mutable/primitiveArrayList.stg b/gs-collections-code-generator/src/main/resources/impl/list/mutable/primitiveArrayList.stg
@@ -958,7 +958,7 @@ public final class <name>ArrayList
 
     public <name>ArrayList sortThis()
     {
-        Arrays.sort(this.items, 0, this.items.length);
+        Arrays.sort(this.items, 0, this.size);
         return this;
     }
 

diff --git a/...ons-code-generator/src/main/resources/test/list/mutable/abstractPrimitiveListTestCase.stg b/...ons-code-generator/src/main/resources/test/list/mutable/abstractPrimitiveListTestCase.stg
@@ -295,6 +295,11 @@ public abstract class Abstract<name>ListTestCase extends AbstractMutable<name>Co
         Mutable<name>List sameList = this.newWith(<["3", "1", "9", "7"]:(literal.(type))(); separator=", ">);
         Assert.assertSame(sameList, sameList.sortThis());
         Assert.assertEquals(<name>ArrayList.newListWith(<["1", "3", "7", "8", "9"]:(literal.(type))(); separator=", ">), this.newWith(<["8", "1", "7", "3", "9"]:(literal.(type))(); separator=", ">).sortThis());
+        Mutable<name>List list = this.newWith();
+        list.add(<(literal.(type))("2")>);
+        list.add(<(literal.(type))("1")>);
+        list.sortThis();
+        Assert.assertEquals(<(literal.(type))("1")>, list.get(0)<(wideDelta.(type))>);
     }
 
     @Test