Skip to content

Commit

Permalink
Misc code style fixes (microsoft#903)
Browse files Browse the repository at this point in the history
Co-authored-by: Adrian Bonar <[email protected]>
  • Loading branch information
dluc and adrianwyatt committed May 10, 2023
1 parent 878587a commit 9e4e2d7
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ private static void AddSemanticTextMemory(this IServiceCollection services)
{
throw new InvalidOperationException("MemoriesStore type is Qdrant and Qdrant configuration is null.");
}

services.AddSingleton<IMemoryStore>(sp => new QdrantMemoryStore(
config.Qdrant.Host, config.Qdrant.Port, config.Qdrant.VectorSize, sp.GetRequiredService<ILogger<QdrantMemoryStore>>()));
services.AddScoped<ISemanticTextMemory>(sp => new SemanticTextMemory(
Expand All @@ -100,6 +101,7 @@ private static void AddSemanticTextMemory(this IServiceCollection services)
{
throw new InvalidOperationException("MemoriesStore type is AzureCognitiveSearch and AzureCognitiveSearch configuration is null.");
}

services.AddSingleton<ISemanticTextMemory>(sp => new AzureCognitiveSearchMemory(config.AzureCognitiveSearch.Endpoint, config.AzureCognitiveSearch.Key));
break;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public Task<Plan> CreatePlanAsync(string goal)
// No functions are available - return an empty plan.
return Task.FromResult(new Plan(goal));
}

return new ActionPlanner(this.Kernel).CreatePlanAsync(goal);
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright (c) Microsoft. All rights reserved.

using System.Text.Json.Serialization;
using SharpYaml.Tokens;

namespace SemanticKernel.Service.Skills.OpenApiSkills.JiraSkill.Model;

Expand All @@ -19,9 +18,9 @@ public class CommentResponse
/// <summary>
/// Initializes a new instance of the <see cref="CommentResponse"/> class.
/// </summary>
/// <param name="allcomments">List of all comments on the Issue.</param>
public CommentResponse(IEnumerable<IndividualComments> allcomments)
/// <param name="allComments">List of all comments on the Issue.</param>
public CommentResponse(IEnumerable<IndividualComments> allComments)
{
this.AllComments = allcomments;
this.AllComments = allComments;
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
// Copyright (c) Microsoft. All rights reserved.

using System.Text.Json.Serialization;
using SemanticKernel.Service.Skills.OpenApiSkills.JiraSkill.Model;

namespace SemanticKernel.Service.Skills.OpenApiSkills;
namespace SemanticKernel.Service.Skills.OpenApiSkills.JiraSkill.Model;

/// <summary>
/// Represents the fields that make up an IssueResponse.
Expand Down Expand Up @@ -37,13 +36,13 @@ public class IssueResponseFields
/// <summary>
/// Initializes a new instance of the <see cref="IssueResponseFields"/> class.
/// </summary>
/// <param name="statuscategorychangedate">The date time the issue was last changed.</param>
/// <param name="statusCategoryChangeDate">The date time the issue was last changed.</param>
/// <param name="summary">The Summary of the issue.</param>
/// <param name="parent">The Parent of the issue.</param>
/// <param name="commentResponse">List of all comments on the issue.</param>
public IssueResponseFields(string statuscategorychangedate, string summary, IssueResponse parent, CommentResponse commentResponse)
public IssueResponseFields(string statusCategoryChangeDate, string summary, IssueResponse parent, CommentResponse commentResponse)
{
this.StatusCategoryChangeDate = statuscategorychangedate;
this.StatusCategoryChangeDate = statusCategoryChangeDate;
this.Summary = summary;
this.Parent = parent;
this.CommentResponse = commentResponse;
Expand Down

0 comments on commit 9e4e2d7

Please sign in to comment.