Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate the rest of README.korean.md #665

Merged
merged 6 commits into from
Apr 6, 2020
Merged

Translate the rest of README.korean.md #665

merged 6 commits into from
Apr 6, 2020

Conversation

songe
Copy link
Contributor

@songe songe commented Apr 1, 2020 •
edited
Loading

Translate README.korean.md

This PR essentially translates the rest of README.korean.md. After this PR, we'll only need to translate the sections into Korean.

  • Update the Collaborators section
  • Update intro & other sections to sound more natural in Korean
  • Fix typos
  • Add the missing code example in section 3.4
  • Translate sections 6 & 7
  • Import @mindock's changes (84c357b) from korean-translation branch

Additionally,

  • Translate sections/projectstructre/breakintcomponents.korean.md

@songe songe force-pushed the master branch 2 times, most recently from 36619df to 415600b Compare April 1, 2020 20:54
@songe
Copy link
Contributor Author

songe commented Apr 1, 2020

Please review, @goldbergyoni !

@songe songe force-pushed the master branch 2 times, most recently from 054741f to b91821a Compare April 5, 2020 05:08
@songe songe changed the title Translate Section 6 into Korean Translate Section 6 & 7 into Korean Apr 5, 2020
@songe songe force-pushed the master branch 2 times, most recently from cc1dfbc to 6a71df6 Compare April 5, 2020 07:51
@songe songe changed the title Translate Section 6 & 7 into Korean Translate the rest of README.korean.md Apr 5, 2020
@songe songe force-pushed the master branch 2 times, most recently from c016367 to ef499ca Compare April 5, 2020 10:05
@songe
Translate README.korean.md
2b32991 
- Update intro & other sections to sound more natural in Korean
- Fix typos
- Add the missing code example in section 3.4
- Translate sections 6 & 7
@songe
Translate breakintcomponents.korean.md
4a1440e 
- Remove 
 from breakintcomponents.korean.md
@songe songe force-pushed the master branch 2 times, most recently from f8523e7 to 2bce0ec Compare April 5, 2020 10:45
goldbergyoni
goldbergyoni approved these changes Apr 6, 2020
View reviewed changes
Copy link
Owner

@goldbergyoni goldbergyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldbergyoni
Copy link
Owner

@songe Looks amazing, did you add youself to the top of the Korean page?

@all-contributors please add @songe for content

@allcontributors
Copy link
Contributor

@goldbergyoni

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@goldbergyoni goldbergyoni merged commit 60d29c3 into goldbergyoni:master Apr 6, 2020
@goldbergyoni
Copy link
Owner

@all-contributors please add @songe for content

@allcontributors allcontributors bot mentioned this pull request Apr 6, 2020
Merged
@allcontributors
Copy link
Contributor

@goldbergyoni

I've put up a pull request to add @songe! 🎉

@songe
Copy link
Contributor Author

songe commented Apr 7, 2020

@songe Looks amazing, did you add youself to the top of the Korean page?

@goldbergyoni I haven't. I can do that in the next PR :) Are you talking about README.korean.md file, or are you talking about a different file?

@songe songe mentioned this pull request Apr 25, 2020
Closed
@goldbergyoni
Copy link
Owner

Both to .korean.md and to the bottom of the main readme.md like shown in this pic 👇

image

@songe
Copy link
Contributor Author

songe commented May 12, 2020

@goldbergyoni Ok, so I understood you correctly the first time. The changes are in #671

@songe songe mentioned this pull request Nov 15, 2020
Closed
elite0226 pushed a commit to elite0226/nodebestpractices that referenced this pull request Oct 31, 2022
@goldbergyoni
Merge pull request goldbergyoni#665 from songe/master
428e4f5 
Translate the rest of README.korean.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldbergyoni goldbergyoni goldbergyoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@songe @goldbergyoni @mindock