Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation: Add reviewed translations for One Paragraph Explainers #363

Merged
merged 9 commits into from
Sep 21, 2019
Merged

Conversation

desko27
Copy link

@desko27 desko27 commented Mar 19, 2019

⛏ What work is being done here?

Only "One Paragraph Explainer" from inner sections are being translated in this PR. For further discussion and planning please take a look at the official spanish translation issue: #95.

📝 Task list

  • Translate 51 "one paragraph explainers" to a private Excel (by Seth)
  • Carefully review and polish translations (by desko27)
  • Actually add them to the PR (by desko27)

✅ Sections 1-5 → Translations from 1 to 34 - 100%

🔄 Section 6 → Translations from 35 to 51 - 0%

@js-kyle js-kyle self-assigned this Mar 20, 2019
@gianpaj
Copy link

gianpaj commented Mar 20, 2019

Great stuff. Andale!

Could you please write in a todo list format - [ ] title what sections are done and what's missing in the translation?

@desko27
Copy link
Author

desko27 commented Mar 20, 2019

@gianpaj ok, I'll try to take a few minutes for it today, maybe tomorrow.

@goldbergyoni
Copy link
Owner

@desko27 Just curious, did we merge all the Excel entries translation we had?

@desko27
Copy link
Author

desko27 commented Mar 24, 2019

@gianpaj I updated the description with the intent of the PR and the current progress 👍

@i0natan as you can see now in the task list, about 50% of the Excel entries were carefully reviewed and introduced into the PR.

I'll write into the main discussion #95 to talk about what the following steps can be. People, thanks again for this wonderful repository, it's very helpful.

@desko27 desko27 changed the title Spanish translation: Add reviewed translations 1-25 Spanish translation: Add reviewed translations for One Paragraph Explainers Mar 24, 2019
@desko27
Copy link
Author

desko27 commented Mar 24, 2019

@i0natan could you add WiP label?

@goldbergyoni
Copy link
Owner

@desko27 to this issue or the home page?

cc @js-kyle

@js-kyle js-kyle added the WIP label Apr 1, 2019
@desko27
Copy link
Author

desko27 commented Apr 29, 2019

Hi guys, just following up on this. I finally had no time on April but I'm having it for May, so let's see if I can complete the remaining 50%!

@goldbergyoni
Copy link
Owner

@desko27 Thanks for the heads-up.

@js-kyle What is the overall status: did we published some Spanish translation? do we want?

@js-kyle
Copy link
Contributor

js-kyle commented May 6, 2019

Awesome @desko27! No, it is still a WIP, but I think it is getting very close

@goldbergyoni
Copy link
Owner

@js-kyle @desko27 Anxiously looking forward to accommodating the most popular language in the world :)

@desko27
Copy link
Author

desko27 commented May 16, 2019

I'm working on it this weekend guys, I want to move this forward. I'll keep you updated!

@desko27
Copy link
Author

desko27 commented Jul 28, 2019

🗓 Pushing on August. Thanks for your patience.

Copy link
Owner

@goldbergyoni goldbergyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💃 🚀

Also very excited that our repo will be available soon in the most popular language on earth

@desko27
Copy link
Author

desko27 commented Sep 13, 2019

Thanks 😄 I'm looking forward to it.

🔴 Section 6 → Translations from 35 to 51 are still missing though.

@goldbergyoni As stated in #95 this branch must be updated since section 6 files are not present in it. How may I approach section 6 translations? Do we update this branch from master? Do we merge this PR and open a new one for section 6? Or I continue to work in this PR after updating the branch?

@js-kyle
Copy link
Contributor

js-kyle commented Sep 21, 2019

As discussed in issue #95, we will merge this, followed by an update to the spanish branch with master

@js-kyle js-kyle merged commit ea78003 into goldbergyoni:spanish-translation Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants