Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1 and 1.2 translated to Korean #229

Merged
merged 9 commits into from
Aug 21, 2018
Merged

1.1 and 1.2 translated to Korean #229

merged 9 commits into from
Aug 21, 2018

Conversation

uronly14me
Copy link
Contributor

Hello, I translated 1.1 and 1.2 to Korean.
Please check them.

@goldbergyoni goldbergyoni self-assigned this Aug 17, 2018
Copy link

@Yitaek Yitaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것은 당신의 어플리케이션에 의존성을 만들고 Express에서만 접근 가능하도록 만든다 (missing "s" in Express)

@uronly14me
Copy link
Contributor Author

@Yitaek Thanks, I fixed that.

@uronly14me
Copy link
Contributor Author

@i0natan Hello, could you review my pull request or should I wait for Korean lead?

@hinco114
Copy link
Contributor

@uronly14me 제가 작업하던 내용보다 더 번역을 잘하신것 같네요.
지금 제가 권한이 없어서 Review 나 Approve 할 수가 없습니다...
Maybe @i0natan will Approve this PR.

@goldbergyoni
Copy link
Owner

@uronly14me Sorry for the delay, looks awsome. Shall we merge to master as well (readers will see partial Koren content) or shall we wait for the entire translation?

@Yitaek Thanks! 👍 👍 👍

@goldbergyoni goldbergyoni merged commit a05541c into goldbergyoni:korean-translation Aug 21, 2018
@uronly14me
Copy link
Contributor Author

@i0natan Yes, please merge this to master! Thanks!

@goldbergyoni
Copy link
Owner

@uronly14me This is handled with high priority, kindly wait few days

elite0226 pushed a commit to elite0226/nodebestpractices that referenced this pull request Oct 31, 2022
…n-uronly14me

1.1 and 1.2 translated to Korean
MatanYadaev pushed a commit to MatanYadaev/nodebestpractices that referenced this pull request Aug 16, 2023
…s/add-Fdawgs

docs: add Fdawgs as a contributor for content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants