Skip to content

autogenerated_exclude: increase scanner buffer #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2020
Merged

autogenerated_exclude: increase scanner buffer #955

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
888446b
autogenerated_exclude: increase scanner buffer
ernado Feb 3, 2020
e084395
autogenerated_exclude: optimize scanner buffer
ernado Feb 3, 2020
fdd533b
autogenerated_exclude: fix typo
ernado Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/result/processors/autogenerated_exclude.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,15 @@ func getDoc(filePath string) (string, error) {
defer file.Close()

scanner := bufio.NewScanner(file)

// Issue 954: Some lines can be very long, e.g. auto-generated
// embedded resources. Reported on file of 86.2KB.
const (
maxSize = 512 * 1024 // 512KB should be enough
initialSize = 4096 // same as startBufSize in bufio
)
scanner.Buffer(make([]byte, initialSize), maxSize)

var docLines []string
for scanner.Scan() {
line := strings.TrimSpace(scanner.Text())
Expand Down