Checkstyle support #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirfag
reviewed
Jun 13, 2018
pkg/printers/checkstyle.go
Outdated
| file.Errors = append(file.Errors, newError) | ||
| } | ||
|
|
||
| out.Files = make([]*checkstyleFile, len(files)) |
Contributor
There was a problem hiding this comment.
maybe make([]*checkstyleFile, 0, len(files))?
Contributor
Author
There was a problem hiding this comment.
This kind of syntax is not supported for maps.
It'll give an error too many arguments to make(map)
https://play.golang.org/p/b7b5e8jgEVp
Contributor
Author
There was a problem hiding this comment.
oh, crap. yes, you're right :)
Contributor
|
thank you for pull request! |
jirfag
approved these changes
Jun 13, 2018
This was referenced Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds checkstyle output format #93