Skip to content

Re-enable gomnd linter with release > v1.23.0 #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2020
Merged

Re-enable gomnd linter with release > v1.23.0 #929

merged 3 commits into from
Jan 20, 2020

Conversation

@ewohltman
Copy link
Contributor

@ewohltman ewohltman commented Jan 20, 2020

Thank you for the pull request!

Please make sure you didn't directly change README.md: it should be changed only by changing README.tmpl.md and running make README.md.

@claassistantio
Copy link

claassistantio commented Jan 20, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ewohltman ewohltman requested review from jirfag and lopezator January 20, 2020 14:53
tpounds
tpounds approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@tpounds tpounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚢

@tpounds tpounds merged commit a5b5598 into golangci:master Jan 20, 2020
@ldez ldez added this to the v1.23 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jirfag jirfag Awaiting requested review from jirfag

@lopezator lopezator Awaiting requested review from lopezator

1 more reviewer

@tpounds tpounds tpounds approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.23

Development

Successfully merging this pull request may close these issues.

4 participants

@ewohltman @claassistantio @tpounds @ldez