Skip to content

Conversation

@sayboras
Copy link
Member

@sayboras sayboras commented Nov 7, 2019

Fixes #847

Recent commit df27992 hides the flag and not showing depreciated message. However, the related test case is still expecting depreciated message

Also fixed one test case in which check-exported is true, but the unused public function message is not expected.

@sayboras sayboras changed the title Testing [WIP] Testing Nov 7, 2019
@sayboras sayboras changed the title [WIP] Testing [WIP] Fixed unit test cases Nov 7, 2019
@sayboras sayboras changed the title [WIP] Fixed unit test cases Fixed unit test cases Nov 7, 2019
@sayboras sayboras changed the title Fixed unit test cases Fixed unit test cases (build failed in master branch) Nov 7, 2019
@sayboras
Copy link
Member Author

sayboras commented Nov 7, 2019

@tpounds @jirfag please help to review this PR. Thanks

Copy link
Contributor

@tpounds tpounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢 it

@tpounds tpounds merged commit 93c0eeb into golangci:master Nov 7, 2019
@ldez ldez added this to the v1.22 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build is failing for master

4 participants