-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitelist regexp and fmt.Errorf global vars #718
Conversation
@korjavin This is a patch that deviates from the upstream repository (https://github.com/leighmcculloch/gochecknoglobals) which means it will make it harder to source directly from that in the future. I'm not sure what @jirfag's policy has been in this regard but my opinion would always be to stay in sync with upstream linters to maintain compatibility with their behavior. |
@korjavin One additional thought is to provide a way to configure additional whitelist rules within |
@korjavin thank you, but I wouldn't like to import patches not from the upstream repository. Why can't you merge it into upstream first? |
I got some good exception from:
https://github.com/bombsimon/gochecknoglobals/tree/whitelisted-selectors