Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist regexp and fmt.Errorf global vars #718

Closed
wants to merge 1 commit into from

Conversation

korjavin
Copy link

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2019

CLA assistant check
All committers have signed the CLA.

@tpounds
Copy link
Contributor

tpounds commented Sep 21, 2019

@korjavin This is a patch that deviates from the upstream repository (https://github.com/leighmcculloch/gochecknoglobals) which means it will make it harder to source directly from that in the future. I'm not sure what @jirfag's policy has been in this regard but my opinion would always be to stay in sync with upstream linters to maintain compatibility with their behavior.

@tpounds
Copy link
Contributor

tpounds commented Sep 21, 2019

@korjavin One additional thought is to provide a way to configure additional whitelist rules within .golangci.yml and/or command line options. This provides more flexibility to all projects without relying on hardcoded rules within the linter. Thoughts?

@jirfag
Copy link
Member

jirfag commented Sep 23, 2019

@korjavin thank you, but I wouldn't like to import patches not from the upstream repository. Why can't you merge it into upstream first?

@jirfag jirfag closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants