Skip to content

Conversation

@tpounds
Copy link
Contributor

@tpounds tpounds commented Sep 20, 2019

Misc. cleanup to dedupe GO111MODULE configurations and enable Go modules across all make targets.

.PHONY: FORCE

# Enable Go module support across all commands.
export GO111MODULE = on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? Go 1.13 has this on by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tariq1890 Go 1.13 defaults it to auto which implies module-awareness by default (see: https://golang.org/doc/go1.13#modules). However, the primary reason for this change is to consolidate all of the places it was being set and to force consistent module on behavior for both Go 1.12 and 1.13 builds in CI (see: https://github.com/golangci/golangci-lint/blob/master/.travis.yml#L2). FWIW, I also tested this change against Go 1.11 locally and it seemed to work fine. It may be possible to re-enable Go 1.11 in CI if there aren't any internal Go runtime/interface issues to be wary of. @jirfag Thoughts?

@jirfag jirfag merged commit 358ce7c into golangci:master Sep 21, 2019
@jirfag
Copy link
Contributor

jirfag commented Sep 21, 2019

thank you, I agree, good change

@tpounds tpounds deleted the always-enable-go-mod branch September 21, 2019 16:07
@ldez ldez added this to the v1.19 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants