Fix unversioned module imports to work with GOPROXY. #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Author
|
The Travis tests are failing, but the diff fails for me at HEAD too. My guess is that the .svg generation is not hermetic and something else has changed since the last run. Do the control files need updating? If this PR has changed something functional please let me know, this is unexpected. |
Author
|
This looks like it's blocked on PR #625, along with the other PRs outstanding at the moment. |
SimonBarendse
approved these changes
Sep 4, 2019
Contributor
|
Might want to add |
2 tasks
All of the imports fixed here failed via proxy.golang.org with 'invalid pseudo-version: does not match version-control timestamp'. This change keeps the same versions but updates the timestamp to something the proxy is happy with as per https://tip.golang.org/doc/go1.13#version-validation.
Contributor
|
Hi, thank you! And sorry for the slow response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the imports fixed here failed via proxy.golang.org with 'invalid pseudo-version: does not match version-control timestamp'. This change keeps the same versions but updates the timestamp to something the proxy is happy with as per https://tip.golang.org/doc/go1.13#version-validation.
One exception is that the bodyclose dep has been really updated to include timakin/bodyclose#17 as per the comment. The previous fix pointed at PR 16.