Skip to content

Conversation

@Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Jul 21, 2024

No description provided.

@ldez ldez added the declined label Jul 21, 2024
@ldez
Copy link
Member

ldez commented Jul 21, 2024

#4831 (comment)

@ldez ldez closed this Jul 21, 2024
@Zxilly
Copy link
Contributor Author

Zxilly commented Jul 21, 2024

Obviously we still have work to do on the SARIF format, and this kind of detection ensures that the sarifs we generate are always valid. We can avoid the problem that we have generated a valid json, but not a valid sarif.

@ldez
Copy link
Member

ldez commented Jul 21, 2024

Obviously we still have work to do on the SARIF format

I don't share your opinion.

this kind of detection ensures that the sarifs we generate are always valid. We can avoid the problem that we have generated a valid json, but not a valid sarif.

This kind of detection will do nothing more than a simple test.
To be detected a problem should exist inside a test case.
However a problem doesn't exist by itself, it requires a specific test case, so the problem will never be detected by the validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants