Skip to content

fix: sanitize level property for SARIF #4831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldez merged 4 commits into from
Jun 19, 2024
Merged

fix: sanitize level property for SARIF #4831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
646a6fd
fix: sarif level property should be enum
Zxilly Jun 19, 2024
d1a7679
review
ldez Jun 19, 2024
9959637
review: add tests
ldez Jun 19, 2024
b4d2ca9
review
ldez Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/printers/sarif.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,12 @@ func (p Sarif) Print(issues []result.Issue) error {
issue := issues[i]

severity := issue.Severity
if severity == "" {

switch severity {
// https://docs.oasis-open.org/sarif/sarif/v2.1.0/errata01/os/sarif-v2.1.0-errata01-os-complete.html#_Toc141790898
case "none", "note", "warning", "error":
// Valid levels.
default:
severity = "error"
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/printers/sarif_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func TestSarif_Print(t *testing.T) {
},
{
FromLinter: "linter-a",
Severity: "error",
Severity: "low",
Text: "some issue 2",
Pos: token.Position{
Filename: "path/to/filec.go",
Expand Down