Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gochecknoinits shadow name #4698

Merged
merged 2 commits into from
May 5, 2024
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented May 5, 2024

A variable name was shadowed by a constant name.

I renamed the constants name to linterName to avoid confusion.

Fixes #4697

@ldez ldez added bug Something isn't working linter: update Update the linter implementation inside golangci-lint labels May 5, 2024
@ldez ldez added this to the next milestone May 5, 2024
@ldez ldez requested review from alexandear and bombsimon May 5, 2024 13:12
@ldez ldez merged commit 4532eb9 into golangci:master May 5, 2024
13 checks passed
@ldez ldez deleted the fix/linter-names branch May 5, 2024 19:43
edigaryev added a commit to cirruslabs/cirrus-cli that referenced this pull request May 7, 2024
jimmidyson added a commit to nutanix-cloud-native/cluster-api-runtime-extensions-nutanix that referenced this pull request May 8, 2024
See golangci/golangci-lint#4697 for details
and waiting on golangci/golangci-lint#4698 to be
released before we can revert this fix.
edigaryev added a commit to cirruslabs/cirrus-cli that referenced this pull request May 8, 2024
* Use Buf Schema Registry

* Update Buf credentials

Co-authored-by: Fedor Korotkov <[email protected]>

* Update Buf credentials

Co-authored-by: Fedor Korotkov <[email protected]>

* Work around golangci/golangci-lint#4698

---------

Co-authored-by: Fedor Korotkov <[email protected]>
jimmidyson added a commit to nutanix-cloud-native/cluster-api-runtime-extensions-nutanix that referenced this pull request May 8, 2024
@ldez ldez modified the milestones: next, v1.58 May 8, 2024
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Sep 12, 2024
…ercloud/fleeting-plugin-hetzner!51)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [golangci/golangci-lint](https://github.com/golangci/golangci-lint) | repository | patch | `v1.58.0` -> `v1.58.1` |

Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions.

---

### Release Notes

<details>
<summary>golangci/golangci-lint (golangci/golangci-lint)</summary>

### [`v1.58.1`](https://github.com/golangci/golangci-lint/releases/tag/v1.58.1)

[Compare Source](golangci/golangci-lint@v1.58.0...v1.58.1)

`golangci-lint` is a free and open-source project built by volunteers.

If you value it, consider supporting us, the [maintainers](https://github.com/golangci/golangci-lint?tab=readme-ov-file#contributors) and [linter authors](https://golangci-lint.run/product/thanks/).

We appreciate it! ❤️

For key updates, see the [changelog](https://golangci-lint.run/product/changelog/#&#8203;1581).

#### Changelog

-   [`dc28153`](golangci/golangci-lint@dc281531) build(deps): bump github.com/4meepo/tagalign from 1.3.3 to 1.3.4 ([#&#8203;4705](golangci/golangci-lint#4705))
-   [`9116634`](golangci/golangci-lint@9116634a) build(deps): bump github.com/ghostiam/protogetter from 0.3.5 to 0.3.6 ([#&#8203;4707](golangci/golangci-lint#4707))
-   [`d64e1de`](golangci/golangci-lint@d64e1de7) build(deps): bump golang.org/x/tools from 0.20.0 to 0.21.0 ([#&#8203;4706](golangci/golangci-lint#4706))
-   [`ee97dbf`](golangci/golangci-lint@ee97dbf7) build(deps): bump golangci/golangci-lint-action from 5.1.0 to 5.3.0 ([#&#8203;4701](golangci/golangci-lint#4701))
-   [`4532eb9`](golangci/golangci-lint@4532eb98) fix: gochecknoinits shadow name ([#&#8203;4698](golangci/golangci-lint#4698))
-   [`6767d7c`](golangci/golangci-lint@6767d7c2) fix: remove GitHub Action problem matchers ([#&#8203;4700](golangci/golangci-lint#4700))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gochecknoinits using undocumented name init
2 participants