Skip to content

feat: allow running only a specific linter without modifying the file configuration #4438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldez merged 5 commits into from
Mar 6, 2024
Merged

feat: allow running only a specific linter without modifying the file configuration #4438

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a049fb9
feat: add an option to only run some linters with the CLI
ldez Feb 27, 2024
e4f9638
chore: minor unrelated changes
ldez Mar 2, 2024
83bcb96
review: --enable-only
ldez Mar 6, 2024
753c17e
chore: LLL...
ldez Mar 6, 2024
6691335
review
ldez Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/commands/flagsets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ func setupLintersFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
fs.StringSliceP("presets", "p", nil,
color.GreenString(fmt.Sprintf("Enable presets (%s) of linters. Run 'golangci-lint help linters' to see "+
"them. This option implies option --disable-all", strings.Join(lintersdb.AllPresets(), "|"))))

fs.StringSlice("enable-only", nil,
color.GreenString("Override linters configuration section to only run the specific linter(s)")) // Flags only.
}

func setupRunFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
Expand Down
28 changes: 25 additions & 3 deletions pkg/config/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,27 @@ func (l *Loader) Load() error {

l.handleGoVersion()

err = l.handleOnlyOption()
if err != nil {
return err
}

return nil
}

func (l *Loader) handleOnlyOption() error {
only, err := l.fs.GetStringSlice("only")
if err != nil {
return err
}

if len(only) > 0 {
l.cfg.Linters = Linters{
Enable: only,
DisableAll: true,
}
}

return nil
}

Expand All @@ -73,13 +94,14 @@ func (l *Loader) handleGoVersion() {

l.cfg.LintersSettings.ParallelTest.Go = l.cfg.Run.Go

trimmedGoVersion := trimGoVersion(l.cfg.Run.Go)

l.cfg.LintersSettings.Gocritic.Go = trimmedGoVersion
if l.cfg.LintersSettings.Gofumpt.LangVersion == "" {
l.cfg.LintersSettings.Gofumpt.LangVersion = l.cfg.Run.Go
}

trimmedGoVersion := trimGoVersion(l.cfg.Run.Go)

l.cfg.LintersSettings.Gocritic.Go = trimmedGoVersion

// staticcheck related linters.
if l.cfg.LintersSettings.Staticcheck.GoVersion == "" {
l.cfg.LintersSettings.Staticcheck.GoVersion = trimmedGoVersion
Expand Down