Skip to content

exhaustive: add missing config #3212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ldez merged 1 commit into from
Sep 11, 2022
Merged

exhaustive: add missing config #3212

ldez merged 1 commit into from
Sep 11, 2022

Conversation

@maratori
Copy link
Contributor

@maratori maratori commented Sep 11, 2022 •
edited
Loading

Several issues were introduced in #3207 to exhaustive linter.
This PR fixes them:

  • Add missing check config
  • Pass package-scope-only config to linter
  • Use explicit-exhaustive-switch config correctly

@maratori maratori mentioned this pull request Sep 11, 2022
Merged
@ldez ldez changed the title fix: exhaustive config exhaustive: add missing config Sep 11, 2022
@ldez ldez added enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint labels Sep 11, 2022
ldez
ldez approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez enabled auto-merge (squash) September 11, 2022 17:03
@ldez ldez merged commit 8a3b754 into golangci:master Sep 11, 2022
@maratori maratori deleted the exhaustive-config branch September 11, 2022 17:16
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@maratori @SeigeC
exhaustive: add missing config (golangci#3212)
3ef8b2f
@ldez ldez added this to the v1.50 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldez ldez ldez approved these changes

Assignees

No one assigned

Labels

enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint

Projects

None yet

Milestone

v1.50

Development

Successfully merging this pull request may close these issues.

2 participants

@maratori @ldez