Skip to content

Conversation

@ldez
Copy link
Member

@ldez ldez commented Aug 21, 2022

Related to #3093 and #2969

Currently, we don't have any linter that required this approach, so I cannot add a test.

The test will look like that:

func TestSourcesFromTestdataSubDir(t *testing.T) {
	subDirs := []string{
		"logrlint",
		"ginkgolinter",
	}

	for _, dir := range subDirs {
		t.Run(dir, func(t *testing.T) {
			testSourcesFromDir(t, filepath.Join(testdataDir, dir))
		})
	}
}

@ldez ldez added enhancement New feature or improvement area: tests Continuous integration, tests and other checks labels Aug 21, 2022
@ldez ldez force-pushed the feat/runner-improve branch from a3b167b to e64d835 Compare August 21, 2022 14:16
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ldez ldez merged commit e1afce4 into golangci:master Aug 21, 2022
@ldez ldez deleted the feat/runner-improve branch August 21, 2022 14:51
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez ldez added this to the v1.49 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: tests Continuous integration, tests and other checks enhancement New feature or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants