fix: exit early on run --version #3067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
bombsimon
approved these changes
Aug 5, 2022
Member
bombsimon
left a comment
bombsimon
left a comment
There was a problem hiding this comment.
LGTM!
Do you know what change made the command not exit successfully after returning nil? Just pondering if it's worth adding some details to why we have to do this
Member
Author
It's because the version is displayed inside the preRun so a |
rski
reviewed
Aug 5, 2022
| if e.cfg.Run.PrintVersion { | ||
| _, _ = fmt.Fprintf(logutils.StdOut, "golangci-lint has version %s built from %s on %s\n", e.version, e.commit, e.date) | ||
| return nil | ||
| os.Exit(exitcodes.Success) // a return nil is not enough to stop the process because we are inside the `preRun`. |
Contributor
There was a problem hiding this comment.
heh, I wondered why we did a return instead of just an exit here :)
rski
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3066