linters/errcheck: add support for ignore/exclude flags #226
Conversation
Add support for the exclude and ignore flags of errcheck. Note that, this commit depends on golangci/errcheck#1. We need to merge it first, update vendors and only then merge this one.
|
Any update on this @jirfag? |
|
hi! |
pkg/commands/run.go
Outdated
| hideFlag("errcheck.check-blank") | ||
| fs.StringVar(&lsc.Errcheck.Exclude, "errcheck.exclude", "", "errcheck.exclude") | ||
| hideFlag("errcheck.exclude") | ||
| lsc.Errcheck.Ignore = config.IgnoreFlag{} |
There was a problem hiding this comment.
set it in defaultLintersSettings please
| fs.BoolVar(&lsc.Errcheck.CheckAssignToBlank, "errcheck.check-blank", false, | ||
| "Errcheck: check for errors assigned to blank identifier: _ = errFunc()") | ||
| hideFlag("errcheck.check-blank") | ||
| fs.StringVar(&lsc.Errcheck.Exclude, "errcheck.exclude", "", "errcheck.exclude") |
There was a problem hiding this comment.
flags creation isn't needed: flags above are preserved just for the compatibility with users who use them.
There was a problem hiding this comment.
IMO, it makes sense to keep the API compatible for both file and CLI configuration.
| return res, nil | ||
| } | ||
|
|
||
| func genConfig(errCfg *config.ErrcheckSettings) (*errcheckAPI.Config, error) { |
There was a problem hiding this comment.
Config not declared by package golangci
| } | ||
|
|
||
| func genConfig(errCfg *config.ErrcheckSettings) (*errcheckAPI.Config, error) { | ||
| c := &errcheckAPI.Config{ |
There was a problem hiding this comment.
Config not declared by package golangci
a8m
force-pushed
the
feat/errcheck-flags
branch
from
6be582f to
fc41dc7
Compare
pkg/golinters/errcheck.go
Outdated
| } | ||
| scanner := bufio.NewScanner(fh) | ||
| for scanner.Scan() { | ||
| name := scanner.Text() |
There was a problem hiding this comment.
declaration of "name" shadows declaration at pkg/golinters/errcheck.go:75
a8m
force-pushed
the
feat/errcheck-flags
branch
2 times, most recently
from
7b548ad to
66f9672
Compare
a8m
force-pushed
the
feat/errcheck-flags
branch
from
66f9672 to
97c698f
Compare
|
Hey @jirfag, thanks for the CR. |
|
thank you! |
4 participants
Follow #223, I've added support for the
excludeandignoreflags of errcheck.Note that, this commit depends on golangci/errcheck#1. We need to merge it first, update vendors and only then merge this one.
Update: all lint errors will disappear after merging golangci/errcheck#1.