gci: Parse the settings more similarly to the cli #2217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gci command line parses the -local flag using the gci.ParseLocalFlag helper function, which is different than strings.Split (which golangci-lint uses) in that it handles the empty string (which golangci-lint separately handles) and that it handles empty entries in the list (which golangci-lint does not handle). For example, the gci command line parses "-local foo,,bar" as the list ["foo", "bar"], but golangci-lint parses the YAML "local-prefixes: foo,,bar" as the list ["foo", "", "bar"]. This is a silly discrepancy to have; just use the gci.ParseLocalFlag helper function!
SVilgelm
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gci command line parses the -local flag using the
gci.ParseLocalFlaghelper function,which is different than
strings.Split(which golangci-lint uses) in that it handles the empty string (which golangci-lint separately handles)and that it handles empty entries in the list (which golangci-lint does not handle).
For example, the gci command line parses
"-local foo,,bar"as the list["foo", "bar"], but golangci-lint parses the YAML"local-prefixes: foo,,bar"as the list["foo", "", "bar"].This is a silly discrepancy to have; just use the
gci.ParseLocalFlaghelper function!