Skip to content

Print error message and exit with non-zero status when ruleguard parse error occurs #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldez merged 8 commits into from
Feb 1, 2021
Merged

Print error message and exit with non-zero status when ruleguard parse error occurs #1666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9e35ec4
Add defer function to recover from ruleguard parse errors
sebastien-rosset Jan 25, 2021
7c639ab
Add defer function to recover from ruleguard parse errors
sebastien-rosset Jan 25, 2021
2503ca7
Add defer function to recover from ruleguard parse errors
sebastien-rosset Jan 25, 2021
0e6d99d
Error handling when go-critic checkers are initialized
sebastien-rosset Jan 31, 2021
d9b263a
Error handling when go-critic checkers are initialized
sebastien-rosset Jan 31, 2021
df0fe3a
Error handling when go-critic checkers are initialized
sebastien-rosset Jan 31, 2021
7cac8d4
Error handling when go-critic checkers are initialized
sebastien-rosset Jan 31, 2021
57926d3
Error handling when go-critic checkers are initialized
sebastien-rosset Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ require (
github.com/denis-tingajkin/go-header v0.4.2
github.com/esimonov/ifshort v1.0.0
github.com/fatih/color v1.10.0
github.com/go-critic/go-critic v0.5.3
github.com/go-critic/go-critic v0.5.4
github.com/go-xmlfmt/xmlfmt v0.0.0-20191208150333-d5b6f63a941b
github.com/gofrs/flock v0.8.0
github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2
Expand Down
16 changes: 11 additions & 5 deletions go.sum
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion pkg/golinters/gocritic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,10 @@ func buildEnabledCheckers(lintCtx *linter.Context, linterCtx *gocriticlinter.Con
return nil, err
}

c := gocriticlinter.NewChecker(linterCtx, info)
c, err := gocriticlinter.NewChecker(linterCtx, info)
if err != nil {
return nil, err
}
enabledCheckers = append(enabledCheckers, c)
}

Expand Down