Skip to content

Conversation

@mattayes
Copy link
Contributor

Note: The test TestSourcesFromTestdataWithIssuesDir/go-header_bad.go is failing on master and was before I made any changes.

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 12, 2021

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@SVilgelm SVilgelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you

@ldez ldez merged commit 257eb95 into golangci:master Jan 12, 2021
@golangci-automator
Copy link

Hey, @mattayes — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@mattayes mattayes deleted the add-fix-to-example branch January 13, 2021 02:32
@ldez ldez mentioned this pull request Feb 13, 2021
3 tasks
ashanbrown pushed a commit to ashanbrown/golangci-lint that referenced this pull request Feb 20, 2021
@ldez ldez added this to the v1.36 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants