Skip to content

Conversation

@iwankgb
Copy link
Contributor

@iwankgb iwankgb commented Dec 12, 2020

We should remove a call to deprecated function.

@iwankgb iwankgb requested a review from a team December 12, 2020 21:45
@iwankgb iwankgb changed the title Cobra.Command.SetOutput is depracated Cobra.Command.SetOutput is deprecated Dec 12, 2020
@iwankgb iwankgb force-pushed the deprecated_setoutput_call branch from bd6d874 to 82aeee3 Compare December 12, 2020 22:01
Copy link
Contributor

@Nivl Nivl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@iwankgb iwankgb merged commit d327987 into master Dec 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the deprecated_setoutput_call branch December 13, 2020 00:01
@ldez ldez added this to the v1.34 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants