Introduce gci as new linter #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daixiang0
changed the title
daixiang0
changed the title
Contributor
Author
|
please review @golangci/core-team |
ernado
reviewed
Jul 27, 2020
sayboras
reviewed
Jul 27, 2020
sayboras
reviewed
Jul 27, 2020
Signed-off-by: Xiang Dai <[email protected]>
sayboras
approved these changes
Jul 28, 2020
Member
sayboras
left a comment
sayboras
left a comment
There was a problem hiding this comment.
apart from configuration point, lgtm 💯
Signed-off-by: Xiang Dai <[email protected]>
ernado
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1257
Signed-off-by: Xiang Dai [email protected]