Added sqlclosecheck to linters #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
sayboras
reviewed
Jul 2, 2020
| @@ -0,0 +1,353 @@ | |||
| //args: -Esqlclosecheck | |||
| package testdata | |||
daixiang0
reviewed
Jul 2, 2020
sayboras
reviewed
Jul 2, 2020
Contributor
Author
|
All feedback should be addressed. Thank you for taking the time to review. |
daixiang0
reviewed
Jul 3, 2020
Contributor
|
/lgtm |
daixiang0
approved these changes
Jul 3, 2020
Contributor
Author
|
Anything I need to do at this point? What's the process for merging and releasing? |
|
Hey, @ryanrolds — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sqlclosecheck linter
The goal of the linter is to identify Rows/Stmt that are not closed or closed using a defer.