Build rpm and deb packages with goreleaser #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
reviewed
Jun 25, 2020
.goreleaser.yml
Outdated
| - | ||
| id: golangci-lint-nfpms | ||
| package_name: golangci-lint | ||
| file_name_template: "'{{ .ProjectName }}-{{ .Version }}-{{ .Os }}-{{ .Arch }}{{ if .Arm }}v{{ .Arm }}{{ end }}" |
Member
There was a problem hiding this comment.
Just want to check if single quote ' in "'{{ .ProjectName }} ... is required.
Member
Author
There was a problem hiding this comment.
Ah, nice catch, that's a copy paste error from me.
sayboras
approved these changes
Jun 26, 2020
Member
sayboras
left a comment
sayboras
left a comment
There was a problem hiding this comment.
LGTM 💯
Seems like we will test this one with new release only.
Contributor
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #988 where we with this commit build
rpmanddebpackages.