Add exportloopref linter #1163
Merged
Add exportloopref linter #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
force-pushed
the
feature/exportloopref
branch
from
07c2097 to
8121e86
Compare
jirfag
reviewed
May 23, 2020
pkg/lint/lintersdb/manager.go
Outdated
| WithPresets(linter.PresetComplexity). | ||
| WithURL("https://github.com/nakabonne/nestif"), | ||
| linter.NewConfig(golinters.NewExportLoopRef()). | ||
| WithPresets(linter.PresetStyle). |
Member
Author
There was a problem hiding this comment.
you are right, bugs present is more appropriate 💯
ernado
reviewed
May 23, 2020
ernado
requested changes
May 23, 2020
Member
ernado
left a comment
ernado
left a comment
There was a problem hiding this comment.
Please address the comments, just two minor points
- Change to PresentBugs - Update URL with https
jirfag
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1041