add ability to set issue severity #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed on severity rules
Member
Author
Member
|
I have no objections, design looks good to me. |
Member
Author
|
One thought I had where this could get complicated is if multiple out formats are supported. It would be difficult to change this to accommodate multiple out formats, atleast not without breaking changes. |
Member
|
cc: @jirfag We can avoid breaking changes via keeping default behavior, so format will change only with explicit configuration. So I'm pretty positive for this feature. |
Member
Author
|
@ernado sounds fair. I will add some tests to this PR |
…ix lint issues, better doc comments, share processor test
Member
Author
|
Tests have been added |
jirfag
requested changes
May 24, 2020
Contributor
jirfag
left a comment
jirfag
left a comment
There was a problem hiding this comment.
awesome work!
code duplication confuses a bit
… rule types, moved severity config to it's own parent key named severity, reduced size of NewRunner function to make it easier to read
…mate reporter easier to read, checkstyle output is now pretty printed
Member
Author
|
@jirfag thanks for the review. Updated based on feedback and added more detail to the PR description |
ernado
approved these changes
May 25, 2020
delete-merged-branch
bot
deleted the
feature/127-add-severity-to-error-messages
branch
|
hi, any plans for releasing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changes:
severityconfig to allow for custom issue severity for out formats that support it based on severity rules. Case sensitive severity rules are supported as wellseveritysupport tocheckstyle,code-climateandgithubout formatscheckstyleout format so humans can read it as wellInternal changes:
Issuestruct namedSeverity. This allows setting severity for issuesIssuestruct namedDescription. This allows reusing logic to create a issue description for printers. It's a combination of linter name and issue textIssuestruct namedFingerprint. This allows reusing logic to create a issue md5 hash for printers. The fingerprint is made up of issue filename, text and if available the first line in the fileBaseRulestruct has been added that allows us to extend the rule code beyond just using it forExcludeRulesBaseRulemethods have 100% test coverageNewRunnermethod easier to read by moving some logic out of it for creating new processorscodeclimatecode easier to read