Skip to content

Conversation

@ced42
Copy link
Contributor

@ced42 ced42 commented May 6, 2020

The Junit output format doesn't validate the Jenkins XSD:
https://github.com/jenkinsci/xunit-plugin/blob/master/src/main/resources/org/jenkinsci/plugins/xunit/types/model/xsd/junit-10.xsd

So, I have added tests, failures and errors attributes on testsuite elements.

@CLAassistant
Copy link

CLAassistant commented May 6, 2020

CLA assistant check
All committers have signed the CLA.

@ced42
Copy link
Contributor Author

ced42 commented May 7, 2020

Hello,

@jirfag , @ernado I have an issue concerning the GITHUB_TOKEN on tests, could you tell me if it is on my side?

Regards,
Cédric.

@jirfag
Copy link
Contributor

jirfag commented May 7, 2020

hi,
thank you,
the issue is that secrets are not passed to workflows that are triggered by a pull request from a fork.
I need to think about what to do with that.

@ced42
Copy link
Contributor Author

ced42 commented May 7, 2020

Hi,

In .github/workflows/tag.yml, I have found this line:
GITHUB_TOKEN: ${{ secrets.GOLANGCI_LINT_TOKEN }}
Shouldn't it be:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
(https://github.com/actions/create-release#example-workflow---create-a-release)

@jirfag
Copy link
Contributor

jirfag commented May 7, 2020

you are right, thank you!
I've fixed it in a master, please, rebase on a master branch

@jirfag jirfag merged commit 7526c8d into golangci:master May 7, 2020
@jirfag
Copy link
Contributor

jirfag commented May 7, 2020

thank you!

@ldez ldez added this to the v1.27 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants