Update gosec linter to v2; add .test files to .gitignore #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This change updates the `gosec` linter to its v2 version. It seems like v2 maintained API compatibility for the functionality we use, so we only needed to update the dependency and imports. Please note, this does not use a tagged version of `gosec` and instead is the latest `master` commit due to this issue: securego/gosec#470. Once this issue is resolved we should update `gosec` to a tagged release. This also adds a line to the `.gitignore` file, to ignore the `.test` output files that get generated by `go test`. This could accidentally get left behind, so no use committing binary files. Fixes golangci#1052
Contributor
|
thank you! |
theckman
added a commit
to theckman/golangci-lint
that referenced
this pull request
May 8, 2020
When raising golangci#1062 I noted that the gosec dependency had been upgraded to v2, but needed to be pulled from `master` due to some issues with the v2.2.0 tagged release. That was tracked in securego/gosec#470. They've since cut v2.3.0, so let's update to that tagged release before we release a new version of golangci-lint.
jirfag
pushed a commit
that referenced
this pull request
May 9, 2020
When raising #1062 I noted that the gosec dependency had been upgraded to v2, but needed to be pulled from `master` due to some issues with the v2.2.0 tagged release. That was tracked in securego/gosec#470. They've since cut v2.3.0, so let's update to that tagged release before we release a new version of golangci-lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
goseclinter to its v2 version. It seems like v2maintained API compatibility for the functionality we use, so we only needed to
update the dependency and imports.
Please note, this does not use a tagged version of
gosecand instead is thelatest
mastercommit due to this issue: securego/gosec#470.Once this issue is resolved we should update
gosecto a tagged release.This also adds a line to the
.gitignorefile, to ignore the.testoutputfiles that get generated by
go test. This could accidentally get left behind,so no use committing binary files.
Fixes #1052