-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Replacing Travis with Github actions #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
|
@ernado you may need to check some configuration options for the repository to enable Github Actions. |
cc5788b to
eab0ca1
Compare
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
|
Oh, great job! Can you please leave Travis for deploy script? |
|
I have already ported and tested it - see PR description. |
|
Oh, now I see. @jirfag PTAL, seems like we should add secrets in settings. |
|
There will be one more for Homebrew but I have no experience with the tool and I have no idea how to authenticate. |
jirfag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thank you!
I've added all GitHub secrets, so we can merge it
| strategy: | ||
| matrix: | ||
| golang: | ||
| - 1.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove 1.12 please to speed up CI like in #1060 . And the same for unix
| goarm: | ||
| - 6 | ||
| - 7 | ||
| gomips: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's wrong with that?
|
I can fix and check |
Important notes:
go.modandgo.sumintools/- I wasn't able to runmake generateotherwisegomipskey in the configurationtimeinMakefileto support builds on Windows.I decided to extend builds to Windows and MacOS but:
Release build was tested for Docker and Github releases. I was not able to test Homebrew. Secrets must be set for hub.docker.com (
GOLANGCI_LINT_DOCKER_TOKEN) and Github (GOLANGCI_LINT_TOKEN) authenticationFixes #1039, supersedes #1054