Re-enable default excludes by ID #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ernado
requested changes
Apr 25, 2020
pkg/config/config.go
Outdated
| } | ||
|
|
||
| func GetDefaultExcludePatternsStrings() []string { | ||
| func GetDefaultExcludePatternsStrings(include []string) []string { |
Member
There was a problem hiding this comment.
Can you please create a new function so we can maintain backward compatibility in API?
E..g. GetExcludePatternsStrings(include []string) that will be called from GetDefaultExcludePatternsStrings().
Contributor
Author
|
Thanks for the lightning-fast review! Updated 👍 |
ernado
approved these changes
Apr 25, 2020
Contributor
Author
|
Thank you @ernado! Easily the fastest turn-around on a PR I've had in a while 😄 Thoughts on when the next release might be cut? |
Member
I'm planning to do it next week, currently busy with github action for golangci-lint :) |
Contributor
Author
|
Ok, no worries! Sounds fun 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds IDs to default exclusions so they can be re-included on a case-by-case basis.
Backward-compatible part of #456