Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update map.sh #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update map.sh #222

wants to merge 1 commit into from

Commits on Apr 28, 2023

  1. Update map.sh

    This pull request optimizes and fixes the bash script by making the following changes:
    
    - Replaced #!/bin/sh with #!/bin/bash to ensure that the script uses bash instead of sh.
    - Renamed the findURL function to find_url to conform to the standard naming convention in bash.
    - Used double quotes instead of single quotes in the find_url function to allow variable expansion.
    - Used sed instead of cut to extract the lesson name from the article filename in the find_url function.
    - Used cd instead of pushd and popd to change directories.
    - Used while read -r instead of echo "$mapping" | while read to avoid a subshell and potential issues with whitespace in the input.
    - Replaced sed "s/[0-9]* //" with cut -d' ' -f2- to extract the title from the mapping input.
    rmdhfz authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    78b106f View commit details
    Browse the repository at this point in the history