Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/cri-o/cri-o: GHSA-w2j5-3rcx-vx7x #363

Closed
GoVulnBot opened this issue Mar 24, 2022 · 3 comments
Assignees
Labels
excluded: NOT_IMPORTABLE This vulnerability only exists in a binary and is not importable.

Comments

@GoVulnBot
Copy link

In GitHub Security Advisory GHSA-w2j5-3rcx-vx7x, there is a vulnerability in the following Go packages or modules:

Unit Fixed Vulnerable Ranges
github.com/cri-o/cri-o 1.19.5 >= 1.18.0, < 1.19.5

See doc/triage.md for instructions on how to triage this report.

package: github.com/cri-o/cri-o
additional_packages:
  - package: github.com/cri-o/cri-o
    versions:
      - introduced: v1.20.0
        fixed: v1.20.6
  - package: github.com/cri-o/cri-o
    versions:
      - introduced: v1.21.0
        fixed: v1.21.5
  - package: github.com/cri-o/cri-o
    versions:
      - introduced: v1.22.0
        fixed: v1.22.2
  - package: github.com/cri-o/cri-o
    versions:
      - introduced: v1.23.0
        fixed: v1.23.1
versions:
  - introduced: v1.18.0
    fixed: v1.19.5
description: |-
    ### Impact
    Before setting the sysctls for a pod, the pods namespaces must be unshared (created). However, in cases where the pod is using a host network or IPC namespace, a bug in CRI-O caused the namespace creating tool [pinns](https://github.com/cri-o/cri-o/tree/main/pinns/) to configure the sysctls of the host. This allows a malicious user to set sysctls on the host, assuming they have access to hostNetwork and hostIPC.

    Any CRI-O cluster after CRI-O 1.18 that drops the infra container
    1.22 and 1.23 clusters drop infra container by default, and are thus vulnerable by default.

    ### Patches
    CRI-O versions 1.24.0, 1.23.1, 1.22.2, 1.21.5, 1.20.6, 1.19.5 all have the patches.

    ### Workarounds
    Users can set `manage_ns_lifecycle` to false, which causes the sysctls to be configured by the OCI runtime, which typically filter these cases. This option is available in 1.20 and 1.19. Newer versions don't have this option.
    An admission webhook could also be created to deny pods that use host IPC or network namespaces and also attempt to configure sysctls related to that namespace.

    ### For more information
    If you have any questions or comments about this advisory:
    * Open an issue in [the CRI-O repo](https://github.com/cri-o/cri-o/issues)
    * To make a report, email your vulnerability to the private
    [[email protected]](mailto:[email protected]) list
    with the security details and the details expected for [all CRI-O bug
    reports](https://github.com/cri-o/cri-o/blob/main/.github/ISSUE_TEMPLATE/bug-report.yml).
published: 2022-03-15T20:02:54Z
last_modified: 2022-03-18T13:40:52Z
ghsas:
  - GHSA-w2j5-3rcx-vx7x

@neild
Copy link
Contributor

neild commented Jul 13, 2022

Vulnerability in tool.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/592767 mentions this issue: data/reports: unexclude 50 reports

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/607216 mentions this issue: data/reports: unexclude 20 reports (14)

gopherbot pushed a commit that referenced this issue Aug 21, 2024
  - data/reports/GO-2022-0314.yaml
  - data/reports/GO-2022-0315.yaml
  - data/reports/GO-2022-0325.yaml
  - data/reports/GO-2022-0328.yaml
  - data/reports/GO-2022-0329.yaml
  - data/reports/GO-2022-0339.yaml
  - data/reports/GO-2022-0340.yaml
  - data/reports/GO-2022-0342.yaml
  - data/reports/GO-2022-0344.yaml
  - data/reports/GO-2022-0348.yaml
  - data/reports/GO-2022-0350.yaml
  - data/reports/GO-2022-0351.yaml
  - data/reports/GO-2022-0353.yaml
  - data/reports/GO-2022-0354.yaml
  - data/reports/GO-2022-0357.yaml
  - data/reports/GO-2022-0358.yaml
  - data/reports/GO-2022-0359.yaml
  - data/reports/GO-2022-0360.yaml
  - data/reports/GO-2022-0363.yaml
  - data/reports/GO-2022-0365.yaml

Updates #314
Updates #315
Updates #325
Updates #328
Updates #329
Updates #339
Updates #340
Updates #342
Updates #344
Updates #348
Updates #350
Updates #351
Updates #353
Updates #354
Updates #357
Updates #358
Updates #359
Updates #360
Updates #363
Updates #365

Change-Id: I88cff49c8c254ce8df68a3fb336657e69cb8ed58
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/607216
Commit-Queue: Tatiana Bradley <[email protected]>
Auto-Submit: Tatiana Bradley <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excluded: NOT_IMPORTABLE This vulnerability only exists in a binary and is not importable.
Projects
None yet
Development

No branches or pull requests

5 participants