Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: add an option to opt out of gopls update prompts completely #963

Closed
stamblerre opened this issue Nov 24, 2020 · 4 comments
Closed
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@stamblerre
Copy link
Contributor

As @hyangah mentioned on https://golang.org/cl/272209:

Some containers (e.g. google cloud shell IDE or github codespace) are released independently, and they don't want to prompt users for the version update unless it's really critical.

This prevents us from updating the hardcoded gopls versions as frequently. Should we have a setting that turns off the update prompts entirely?

@stamblerre stamblerre added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Nov 24, 2020
@hyangah
Copy link
Contributor

hyangah commented Nov 24, 2020

An alternative option is to repurpose "go.useGoProxyToCheckForToolUpdates".
This is not particularly intuitive - and some users were confused and expected it to prevent the version checks completely.

Or, maybe deprecate and replace it with "go.checkForToolUpdates" which can be off, local, proxy (default). If there are users who don't want to go out to the network, but want to make sure their versions meet the minimum requirements hardcoded in the extension.

@AlbinoGeek
Copy link

AlbinoGeek commented Dec 12, 2020

Please, because often (especially when testing new gopls versions) you have to install them manually, and the periodic tool update check actually offers you to downgrade from the versions you have manually installed, it can be quite obtuse.

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/278353 mentions this issue: package.json: add go.toolsManagement.checkForUpdates

gopherbot pushed a commit that referenced this issue Dec 17, 2020
This deprecates go.useGoProxyToCheckForToolUpdates.
And, add go.toolsManagement.checkForUpdates off mode
that avoids version check entirely.

We will start actively prompting users of this change
from the next release. We don't do that right now to avoid
prompt until dev containers update their settings and
get released.

Updates #963

Change-Id: Id49103b37e2e6e19f0313792d7d3e72648e84ce5
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/278353
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
@hyangah hyangah added this to the v0.20.0 milestone Dec 21, 2020
@hyangah
Copy link
Contributor

hyangah commented Dec 21, 2020

'"go.toolsManagement.checkForUpdates": "off"` will completely disable any version checking. Not recommended unless it's used in actively maintained dev containers.

Also, when testing new gopls versions manually installed, our extension shouldn't prompt for update if the gopls binary was built in modules mode correctly. If you find otherwise, that's a bug and please file an issue.

@hyangah hyangah closed this as completed Dec 21, 2020
@golang golang locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

No branches or pull requests

4 participants