Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: embed signed vscgo binaries in the extension #3186

Open
hyangah opened this issue Feb 21, 2024 · 3 comments
Open

release: embed signed vscgo binaries in the extension #3186

hyangah opened this issue Feb 21, 2024 · 3 comments
Assignees
@hyangah
Milestone
v0.44.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Feb 21, 2024

Follow up of #3182

Then, revert the change https://go.dev/cl/565679 to enable vscgo on windows.
@hyangah hyangah added this to the v0.42.0 milestone Feb 21, 2024
@hyangah hyangah self-assigned this Feb 21, 2024
@hyangah hyangah mentioned this issue Feb 22, 2024
Closed
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/571575 mentions this issue: internal/relui/sign: add binary artifact signing modes

gopherbot pushed a commit to golang/build that referenced this issue Apr 5, 2024
@hyangah @gopherbot
internal/relui/sign: add binary artifact signing modes
914cd3b 
For golang/vscode-go#3186

Change-Id: I684e222cc018b18ad0c173522dfd70cb3b34e0ca
Reviewed-on: https://go-review.googlesource.com/c/build/+/571575
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/587735 mentions this issue: internal/task: change buildVSCGO to produce zip files

gopherbot pushed a commit to golang/build that referenced this issue May 24, 2024
@hyangah
internal/task: change buildVSCGO to produce zip files
d152727 
Signing service expects zip as input. Pack the binary in a zip file.
The file name is <randomnumber>-<platform>-vscgo.zip.

For golang/vscode-go#3186

Change-Id: I7d91dfbd2b5f0c4386421c2abfe77df254b392fb
Reviewed-on: https://go-review.googlesource.com/c/build/+/587735
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@siegenthalerroger siegenthalerroger mentioned this issue Jun 6, 2024
Open
@hyangah hyangah modified the milestones: v0.42.0, v0.43.0 Jul 15, 2024
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/595376 mentions this issue: extension/tools/release: add build-vscgo subcommand

gopherbot pushed a commit that referenced this issue Aug 28, 2024
@hyangah
extension/tools/release: add build-vscgo subcommand
12353fd 
This subcommand cross-compiles the tagged version of vscgo
for all targets we want to release prebuilt vscgo binaries for.
It uses `go install github.com/golang/vscode-go/vscgo@<TAG_NAME>`
to compile the binary, in order to embed useful build info
(so, we can have meaningful telemetry). After go1.24
(golang/go#50603) we will be able to use
`go build` instead.

The output of this subcommand is "vscgo.zip" in the -out directory.

The test involves running the `go install` and checking
the compiled binaries included in the vscgo.zip file
have expected GOOS/GOARCH. For hermetic unit testing,
the test creates a file-based module proxy using the code
copied from golang.org/x/telemetry/internal/proxy.

For #3186

Change-Id: I45848fdb676d094c634786ac939481f1778b4995
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/595376
Reviewed-by: Hongxiang Jiang <[email protected]>
kokoro-CI: kokoro <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
@hyangah hyangah modified the milestones: v0.43.0, v0.44.0 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyangah hyangah

Labels
None yet
Projects
None yet
Milestone
v0.44.0
Development

No branches or pull requests
2 participants
@hyangah @gopherbot