-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gopls/internal/undeclaredname: add missing colon when appropriate #545
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 593ee32) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
This PR (HEAD: cfb4da6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
Message from xxx Lulu: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from xxx Lulu: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
This PR (HEAD: e55a4db) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
This PR (HEAD: 7fa8370) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
baf803d
to
6d673ec
Compare
This PR (HEAD: 6d673ec) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
This PR (HEAD: bf9874e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
This CL improves the undeclared-variable quick fix
by adding the missing colon when appropriate, that is:
function is an AssignStmt, and it sits in the left hand side;
Prior to this CL:
the cursor position, while this CL insert it before the first
undefined ident with the same name.
so this CL also adds a default value derived from its type.
Fixes golang/go#69980