gopls/internal/codeaction: replace all occurrences of expression (refactor.extract.variable.all) #539

xzbdmw · 2024-10-31T17:32:36Z

This change introduces a new refactoring code action
"Extract n occurrences of expression".

The original "Extract Variable" is treated as a limited version
of "Extract n occurrences of expression", they share the same
underlying implementation. The difference is that
"extract_all" utilizes a slice of structural equal expression
by searching through the entire function body, while the limited
version simply append the expression under selection to that slice.

Also:

change default variable name from "x" to "newVar",
default const name from "k" to "newConst",
users will almost always perform a rename after
extraction, so this change make it more discoverable,
especially when there are multiple matches.
add marker test extract_expressions.txt and
extract_expressions_resolve.txt.

Updates golang/go#70085
Fixes golang/go#70563

gopherbot · 2024-10-31T17:45:29Z

This PR (HEAD: 4e59087) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-31T18:00:38Z

This PR (HEAD: 00f4d8a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T07:41:52Z

This PR (HEAD: 2eeb2c4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T08:58:34Z

This PR (HEAD: 0c4ddaf) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T09:26:03Z

This PR (HEAD: 2f839f4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T10:28:39Z

This PR (HEAD: 78461fc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T11:41:56Z

This PR (HEAD: 0324b69) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T11:58:40Z

This PR (HEAD: 83f4dc3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T12:32:57Z

This PR (HEAD: 8581970) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T18:18:50Z

This PR (HEAD: 51938d2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-02T07:24:52Z

This PR (HEAD: f935517) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-02T09:48:40Z

This PR (HEAD: 26fbd88) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-11T17:29:11Z

Message from Alan Donovan:

Patch Set 55:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-11T18:22:47Z

This PR (HEAD: f7bbcb7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-11T18:32:19Z

Message from xxx Lulu:

Patch Set 55:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-11T18:41:03Z

Message from Alan Donovan:

Patch Set 55: Code-Review+2 Commit-Queue+1

Copied votes on follow-up patch sets have been updated:

Code-Review+2 has been copied to patch set 56 (copy condition: "is:ANY").

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-11T18:41:09Z

This PR (HEAD: 36c6313) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-11T18:59:06Z

Message from xxx Lulu:

Patch Set 56:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-11T19:17:05Z

Message from Alan Donovan:

Patch Set 57: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-11T19:26:34Z

This PR (HEAD: a02dc30) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-11T19:35:50Z

Message from xxx Lulu:

Patch Set 57:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-11T20:04:04Z

Message from Alan Donovan:

Patch Set 58: Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-11T20:04:05Z

Message from Alan Donovan:

Patch Set 58:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-11T20:57:57Z

This PR (HEAD: d614fb5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-11T21:06:43Z

Message from xxx Lulu:

Patch Set 58:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-11T21:06:49Z

This PR (HEAD: e22276d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-11T21:15:29Z

Message from xxx Lulu:

Patch Set 59:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-11T21:24:45Z

Message from Alan Donovan:

Patch Set 59: Code-Review+2

Copied votes on follow-up patch sets have been updated:

Code-Review+2 has been copied to patch set 60 (was Code-Review+1) (copy condition: "is:ANY").

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

new test zz reflect diable in lhs

gopherbot · 2024-12-18T00:36:24Z

This PR (HEAD: b66a18d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

xzbdmw changed the title ~~gopls/internal/codeaction: Replace All Occurrences of Expression~~ gopls/internal/codeaction: Replace all occurrences of expression Oct 31, 2024

xzbdmw changed the title ~~gopls/internal/codeaction: Replace all occurrences of expression~~ gopls/internal/codeaction: replace all occurrences of expression ("refactor.extract.variable.all") Oct 31, 2024

xzbdmw changed the title ~~gopls/internal/codeaction: replace all occurrences of expression ("refactor.extract.variable.all")~~ gopls/internal/codeaction: replace all occurrences of expression (refactor.extract.variable.all) Oct 31, 2024

xzbdmw force-pushed the replace_all branch from 44bfbc7 to 4e59087 Compare October 31, 2024 17:42

xzbdmw force-pushed the replace_all branch from 4e59087 to 00f4d8a Compare October 31, 2024 17:53

xzbdmw force-pushed the replace_all branch from 00f4d8a to 2eeb2c4 Compare November 1, 2024 07:41

xzbdmw force-pushed the replace_all branch from 2eeb2c4 to 0c4ddaf Compare November 1, 2024 08:51

xzbdmw force-pushed the replace_all branch from 0c4ddaf to 2f839f4 Compare November 1, 2024 09:25

xzbdmw force-pushed the replace_all branch from 2f839f4 to 78461fc Compare November 1, 2024 10:24

xzbdmw force-pushed the replace_all branch 2 times, most recently from 30abec2 to 0324b69 Compare November 1, 2024 11:37

xzbdmw force-pushed the replace_all branch 3 times, most recently from 37c7b7b to 83f4dc3 Compare November 1, 2024 11:57

xzbdmw force-pushed the replace_all branch from 83f4dc3 to 8581970 Compare November 1, 2024 12:25

xzbdmw force-pushed the replace_all branch from 8581970 to 51938d2 Compare November 1, 2024 18:15

xzbdmw force-pushed the replace_all branch from 51938d2 to f935517 Compare November 2, 2024 07:18

xzbdmw force-pushed the replace_all branch from f935517 to 26fbd88 Compare November 2, 2024 09:44

xzbdmw force-pushed the replace_all branch from 114383c to f7bbcb7 Compare December 11, 2024 18:15

xzbdmw force-pushed the replace_all branch 3 times, most recently from 56da86a to 36c6313 Compare December 11, 2024 18:40

xzbdmw force-pushed the replace_all branch 4 times, most recently from 330446e to a02dc30 Compare December 11, 2024 19:24

xzbdmw force-pushed the replace_all branch from a02dc30 to d614fb5 Compare December 11, 2024 20:50

xzbdmw force-pushed the replace_all branch 2 times, most recently from 34d0e27 to e22276d Compare December 11, 2024 21:01

replace_all

b66a18d

new test zz reflect diable in lhs

xzbdmw force-pushed the replace_all branch from e22276d to b66a18d Compare December 18, 2024 00:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gopls/internal/codeaction: replace all occurrences of expression (refactor.extract.variable.all) #539

gopls/internal/codeaction: replace all occurrences of expression (refactor.extract.variable.all) #539

xzbdmw commented Oct 31, 2024 •

edited

Loading

gopherbot commented Oct 31, 2024

gopherbot commented Oct 31, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 2, 2024

gopherbot commented Nov 2, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 18, 2024

gopls/internal/codeaction: replace all occurrences of expression (refactor.extract.variable.all) #539

Are you sure you want to change the base?

gopls/internal/codeaction: replace all occurrences of expression (refactor.extract.variable.all) #539

Conversation

xzbdmw commented Oct 31, 2024 • edited Loading

gopherbot commented Oct 31, 2024

gopherbot commented Oct 31, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 2, 2024

gopherbot commented Nov 2, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 18, 2024

xzbdmw commented Oct 31, 2024 •

edited

Loading