-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completions/inference: infer polymorphic types in completions #530
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 152e295) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/618675. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Jacob Zimmerman: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Robert Findley: Patch Set 2: (10 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
This PR (HEAD: 8158e3b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/618675. Important tips:
|
8158e3b
to
05a7636
Compare
This PR (HEAD: 05a7636) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/618675. Important tips:
|
This PR (HEAD: 33eefce) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/618675. Important tips:
|
This PR (HEAD: 0942b32) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/618675. Important tips:
|
Message from Jacob Zimmerman: Patch Set 5: (14 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Jacob Zimmerman: Patch Set 6: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Robert Findley: Patch Set 6: (10 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
0942b32
to
3398f2e
Compare
This PR (HEAD: 3398f2e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/618675. Important tips:
|
Message from Jacob Zimmerman: Patch Set 6: (11 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
This PR (HEAD: 24996af) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/618675. Important tips:
|
Message from Robert Findley: Patch Set 8: (16 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
This PR (HEAD: 551bd57) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/618675. Important tips:
|
Message from Robert Findley: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Jacob Zimmerman: Patch Set 9: (14 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Jacob Zimmerman: Patch Set 9: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Jacob Zimmerman: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
This PR (HEAD: 3e5fc1b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/618675. Important tips:
|
Message from Jacob Zimmerman: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Robert Findley: Patch Set 10: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Robert Findley: Patch Set 10: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Go LUCI: Patch Set 10: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-11-21T17:45:49Z","revision":"f6717bc57afe4965d1beb177953b569cf4009d1f"} Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Robert Findley: Patch Set 10: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Go LUCI: Patch Set 10: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-arm64 has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Go LUCI: Patch Set 10: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
Message from Robert Findley: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/618675. |
When using generic functions, the LSP now tries to infer an instantiation
based on the surroundings of the call expression. If successful, it improves
completions for parameters of generic functions. It shouldn't collide
with any pre-existing code paths.
Fixes golang/go#69754