-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/callgraph/rta: add rta analysis test case for multiple go packages #513
Conversation
xieyuschen
commented
Aug 29, 2024
•
edited
Loading
edited
- use go/packages to load packages
* use go/packages to load packages
cb4351b
to
b74ce25
Compare
This PR (HEAD: b74ce25) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/609576. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
Message from Tim King: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
Message from Zvonimir Pavlinovic: Patch Set 1: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
This PR (HEAD: 391c42c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/609576. Important tips:
|
Message from Xie Yuchen: Patch Set 2: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
Message from Xie Yuchen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
Message from Zvonimir Pavlinovic: Patch Set 2: (9 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
087021e
to
9df8625
Compare
9df8625
to
a4bb031
Compare
Message from Xie Yuchen: Patch Set 2: (8 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
Message from Xie Yuchen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
Message from Xie Yuchen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
This PR (HEAD: a4bb031) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/609576. Important tips:
|
Message from Alan Donovan: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
This PR (HEAD: 4b40bbc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/609576. Important tips:
|
Message from Xie Yuchen: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
Message from Alan Donovan: Patch Set 4: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
This PR (HEAD: fcd40ad) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/609576. Important tips:
|
fcd40ad
to
deda7b7
Compare
This PR (HEAD: deda7b7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/609576. Important tips:
|
Message from Xie Yuchen: Patch Set 5: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
Message from Alan Donovan: Patch Set 6: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
Message from Xie Yuchen: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
Message from Tim King: Patch Set 6: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
This PR (HEAD: a859e27) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/609576. Important tips:
|
Message from Xie Yuchen: Patch Set 6: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
Message from Tim King: Patch Set 7: Code-Review+2 Commit-Queue+1 (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-04T19:44:55Z","revision":"7a9c20f34a4dbf3f99f53cab83a6476deeb923c8"} Please don’t reply on this GitHub thread. Visit golang.org/cl/609576. |
* use go/packages to load packages Change-Id: I6e9f81b282cddc186b4905a23ff635cd98245ac8 GitHub-Last-Rev: a859e27 GitHub-Pull-Request: #513 Reviewed-on: https://go-review.googlesource.com/c/tools/+/609576 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Tim King <[email protected]> Reviewed-by: Alan Donovan <[email protected]>
This PR is being closed because golang.org/cl/609576 has been merged. |