SignatureHelp: report signature of Ident if no enclosing CallExpr #510

crazyhulk · 2024-08-17T03:25:16Z

Currently, SignatureHelp reports information only about an
enclosing call expression. But it would be useful to show
signature information after entering the name of a function
such as "f" or "fmt.Println", without call parens.

So, if there is no enclosing call, this change reports the
signature of the selected identifier if it is callable.

Fixes golang/go#68922

google-cla · 2024-08-17T03:25:20Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2024-08-17T03:52:44Z

This PR (HEAD: edafbe5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/605983.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-17T03:59:17Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-17T04:05:43Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-18T15:18:02Z

This PR (HEAD: e12fe98) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/605983.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-19T04:17:49Z

This PR (HEAD: b4e98e7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/605983.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-20T04:37:43Z

Message from xizi:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-21T17:47:21Z

Message from Robert Findley:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-21T18:21:09Z

Message from Robert Findley:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T08:20:28Z

This PR (HEAD: 98dc288) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/605983.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-22T08:27:39Z

This PR (HEAD: cb31975) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/605983.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-22T10:07:39Z

This PR (HEAD: 5dfaf73) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/605983.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-22T10:14:27Z

Message from xizi:

Patch Set 7:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T10:57:14Z

This PR (HEAD: 90d74b9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/605983.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-22T13:25:55Z

Message from Robert Findley:

Patch Set 9: Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T14:56:06Z

This PR (HEAD: eaa1d0e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/605983.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-22T16:14:04Z

Message from xizi:

Patch Set 10:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T16:20:50Z

Message from xizi:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T16:40:58Z

Message from Alan Donovan:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-11T16:27:30Z

This PR (HEAD: 62bd45e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/605983.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-11T16:42:16Z

Message from xizi:

Patch Set 22:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-11T16:49:16Z

Message from Alan Donovan:

Patch Set 23: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-11T16:56:48Z

Message from Go LUCI:

Patch Set 23:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-11T16:41:57Z","revision":"f0691c48877d4cdc48a42467b064b60b2960eb29"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-11T16:56:48Z

Message from Alan Donovan:

Patch Set 23: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-11T16:56:49Z

Message from Go LUCI:

Patch Set 23:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-arm64-boringcrypto has failed with summary (view all results):

go on master (commit ec67622)
tools on master (change 605983)

Build or test failure, click here for results.

To reproduce, try gomote repro 8737075075114063329.

Additional links for debugging:

Output for test golang.org/x/tools/gopls module

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-11T16:56:49Z

Message from Go LUCI:

Patch Set 23: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-11T18:43:00Z

Message from Robert Findley:

Patch Set 23: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

Currently, signatures can only be returned within the parentheses when use lsp."textDocument/signatureHelp"; they cannot be returned on the function name. Because we prefere to use "." to trigger a code complete menu, we also need the ability to retrieve function signatures Fixes golang/go#68922

gopherbot · 2024-09-12T02:47:44Z

This PR (HEAD: 5e7965e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/605983.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-12T03:00:52Z

Message from xizi:

Patch Set 24:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-12T14:33:30Z

Message from Robert Findley:

Patch Set 24: Auto-Submit+1 Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-12T14:33:30Z

Message from Go LUCI:

Patch Set 24:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-12T14:24:39Z","revision":"21a0ead3392ee6938ffc100537085ae0d0d44efc"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/605983.
After addressing review feedback, remember to publish your drafts!

Currently, SignatureHelp reports information only about an enclosing call expression. But it would be useful to show signature information after entering the name of a function such as "f" or "fmt.Println", without call parens. So, if there is no enclosing call, this change reports the signature of the selected identifier if it is callable. Fixes golang/go#68922 Change-Id: Ibb0700e354c5d6e5937fc7f7b5db65e9d96574bb GitHub-Last-Rev: 5e7965e GitHub-Pull-Request: #510 Reviewed-on: https://go-review.googlesource.com/c/tools/+/605983 Reviewed-by: Alan Donovan <[email protected]> Reviewed-by: Robert Findley <[email protected]> Auto-Submit: Robert Findley <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>

gopherbot · 2024-09-12T14:48:28Z

This PR is being closed because golang.org/cl/605983 has been merged.

crazyhulk closed this Aug 17, 2024

crazyhulk reopened this Aug 17, 2024

crazyhulk closed this Aug 17, 2024

crazyhulk reopened this Aug 17, 2024

crazyhulk force-pushed the master branch from 70a37f2 to edafbe5 Compare August 17, 2024 03:52

crazyhulk force-pushed the master branch from edafbe5 to e12fe98 Compare August 18, 2024 15:14

crazyhulk force-pushed the master branch from e12fe98 to b4e98e7 Compare August 19, 2024 04:13

crazyhulk force-pushed the master branch from 98dc288 to cb31975 Compare August 22, 2024 08:23

crazyhulk changed the title ~~gopls/internal/golang: get signature when cusor is over the function name~~ gopls/internal/golang: get sign when the cusor is over the function name Aug 22, 2024

crazyhulk force-pushed the master branch from 5dfaf73 to 90d74b9 Compare August 22, 2024 10:50

crazyhulk force-pushed the master branch from 7561568 to eaa1d0e Compare August 22, 2024 14:52

crazyhulk added 14 commits September 12, 2024 10:44

try to get sign from ident

dfe09e0

add test cases

c3f381a

reset gopls/internal/test/integration/misc/signature_help_test.go

169fcf0

fix: Work on both the function name and the identifier

22f52bb

remove test code

e8c77b0

refactor: remove unnecessary code

2cbb0e8

fix: ident signature help && add test

4250037

add release note placeholders

10b63ab

fix: func value inside the parentheses of another function call

df6634f

add release note

e2347c9

make doc precise

981feab

refactor code & add more test

657749f

make code more clear

5e7965e

crazyhulk force-pushed the master branch from 62bd45e to 5e7965e Compare September 12, 2024 02:44

gopherbot closed this Sep 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SignatureHelp: report signature of Ident if no enclosing CallExpr #510

SignatureHelp: report signature of Ident if no enclosing CallExpr #510

crazyhulk commented Aug 17, 2024 •

edited

Loading

google-cla bot commented Aug 17, 2024

gopherbot commented Aug 17, 2024

gopherbot commented Aug 17, 2024

gopherbot commented Aug 17, 2024

gopherbot commented Aug 18, 2024

gopherbot commented Aug 19, 2024

gopherbot commented Aug 20, 2024

gopherbot commented Aug 21, 2024

gopherbot commented Aug 21, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 12, 2024

gopherbot commented Sep 12, 2024

gopherbot commented Sep 12, 2024

gopherbot commented Sep 12, 2024

gopherbot commented Sep 12, 2024

SignatureHelp: report signature of Ident if no enclosing CallExpr #510

SignatureHelp: report signature of Ident if no enclosing CallExpr #510

Conversation

crazyhulk commented Aug 17, 2024 • edited Loading

google-cla bot commented Aug 17, 2024

gopherbot commented Aug 17, 2024

gopherbot commented Aug 17, 2024

gopherbot commented Aug 17, 2024

gopherbot commented Aug 18, 2024

gopherbot commented Aug 19, 2024

gopherbot commented Aug 20, 2024

gopherbot commented Aug 21, 2024

gopherbot commented Aug 21, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 11, 2024

gopherbot commented Sep 12, 2024

gopherbot commented Sep 12, 2024

gopherbot commented Sep 12, 2024

gopherbot commented Sep 12, 2024

gopherbot commented Sep 12, 2024

crazyhulk commented Aug 17, 2024 •

edited

Loading