Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/ssa: add position data in indexed range loops #190

Closed
wants to merge 1 commit into from
Closed

go/ssa: add position data in indexed range loops #190

wants to merge 1 commit into from
+3 −0

Conversation

vovapi
Copy link
Contributor

@vovapi vovapi commented Nov 23, 2019 •
edited
Loading

Indexed range loops are lacking position data
in their SSA representation, so add the position data
into an index operation.

This improves the nilness output by providing position data
with the message.

Updates golang/go#31008

@vovapi
go/ssa: add position data in indexed range loops
75831d2 
Indexed range loops are lacking position data
in their SSA representation, so add the position data
into an index operation

This improves the problem described in golang/go#31008
by providing position data with the nilness message
@gopherbot
Copy link
Contributor

This PR (HEAD: 75831d2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/208599 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 1:

Hi, sorry for the delay on this small CL. This change seems entirely reasonable, but I'm ramping up on go/ssa and want to understand the library better before LGTM'ing. I'll try to get this done this week, and get a +2 from either Ian or Michael after the holiday break.

Thanks for being patient!

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 1: Code-Review+1

(1 comment)

Patch Set 1:

Hi, sorry for the delay on this small CL. This change seems entirely reasonable, but I'm ramping up on go/ssa and want to understand the library better before LGTM'ing. I'll try to get this done this week, and get a +2 from either Ian or Michael after the holiday break.

Thanks for being patient!

LGTM modulo my comment on the commit message. This definitely improves the nilness error message. Thanks again!

Will +2 after discussing the problem with Michael.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Vladimir Evgrafov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 2: Run-TryBot+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=cc284232

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/77c13021/freebsd-amd64-12_0_d51f8ba9.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 4: Patch Set 3 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 4: Run-TryBot+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=deb7d074

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 4: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/208599.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jan 9, 2020
@vovapi @findleyr
go/ssa: add position data in indexed range loops
ac4f524 
Indexed range loops are lacking position data
in their SSA representation, so add the position data
into an index operation.

This improves the nilness output by providing position data
with the message.

Updates golang/go#31008

Change-Id: I664c8668bc74207e770657e21129d20fd70e7af6
GitHub-Last-Rev: 75831d2
GitHub-Pull-Request: #190
Reviewed-on: https://go-review.googlesource.com/c/tools/+/208599
Run-TryBot: Robert Findley <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/208599 has been merged.

@gopherbot gopherbot closed this Jan 9, 2020
@vovapi vovapi deleted the range-indexed-pos branch January 10, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vovapi @gopherbot @googlebot