Skip to content

Commit

Permalink
cmd/godoc: expand skips in TestWeb
Browse files Browse the repository at this point in the history
After CL 403534, another TestWeb failure was observed in
https://build.golang.org/log/24cca44e99d848317a6bb73b6d15528b500e5643.
This change expands the skips to try to cover more of the cases
where cmd/godoc might hang.

For golang/go#50014.

Change-Id: If3f08da69a68dc00c399b89ffb2c4f049114aeb6
Reviewed-on: https://go-review.googlesource.com/c/tools/+/403849
Auto-Submit: Bryan Mills <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
  • Loading branch information
Bryan C. Mills authored and gopherbot committed May 4, 2022
1 parent 4911e4a commit d27d783
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cmd/godoc/godoc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func waitForSearchReady(t *testing.T, cmd *exec.Cmd, addr string) {
2*time.Minute,
false)
if err := <-ch; err != nil {
t.Fatal(err)
t.Skipf("skipping due to https://go.dev/issue/50014: %v", err)
}
}

Expand All @@ -111,7 +111,7 @@ func waitUntilScanComplete(t *testing.T, addr string) {
true,
)
if err := <-ch; err != nil {
t.Fatal(err)
t.Skipf("skipping due to https://go.dev/issue/50014: %v", err)
}
}

Expand Down

0 comments on commit d27d783

Please sign in to comment.