Skip to content

Commit

Permalink
internal/lsp/tests: disable failing test on ARM
Browse files Browse the repository at this point in the history
This is a stopgap until I can diagnost the problem, but in the meantime
we need to fix the builders.

Updates golang/go#54655

Change-Id: I6260828e8c07e3121c45f99166a26d51aa9805a4
Reviewed-on: https://go-review.googlesource.com/c/tools/+/425575
Run-TryBot: Alan Donovan <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
gopls-CI: kokoro <[email protected]>
Reviewed-by: Tim King <[email protected]>
  • Loading branch information
adonovan committed Aug 25, 2022
1 parent d35bb19 commit 2f38e1d
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions internal/lsp/tests/tests.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
"os"
"path/filepath"
"regexp"
"runtime"
"sort"
"strconv"
"strings"
Expand Down Expand Up @@ -710,6 +711,13 @@ func Run(t *testing.T, tests Tests, data *Data) {
if shouldSkip(data, spn.URI()) {
continue
}
// Temporarily suppress test failing on some ARM builders.
// https://github.com/golang/go/issues/54655.
// TODO(adonovan): reenable along with fix.
if name := SpanName(spn); runtime.GOARCH == "arm64" && (name == "a4_28_18" || name == "a4_35_20") {
t.Logf("skipping test %s on GOARCH=arm64", name)
continue
}
t.Run(SpanName(spn), func(t *testing.T) {
t.Helper()
tests.SuggestedFix(t, spn, actionKinds, 1)
Expand Down

0 comments on commit 2f38e1d

Please sign in to comment.